| thiemowmde closed this task as "Invalid". thiemowmde moved this task from in current sprint to needs discussion or investigation on the Wikidata board. thiemowmde added a comment. |
I will close this ticket for now because it seems to fulfill no purpose.
- The mentioned patch was merged 8 months ago.
- The tickets title is as vague as it can be. "Refactor" is a continuous process, nothing we can or should track.
- There are no acceptance criteria.
- I don't think it is even possible to remove all "global state" and "database" access from this test. From what I understand it is more an integration test, which means it should also test the integration with the database. That database should be a fast SQLite one during tests for performance reasons, but still an actual database.
I'm not saying the file repo/tests/phpunit/includes/Api/EditEntityTest.php doesn't need refactoring, because it does.
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: thiemowmde, daniel, Aklapper, Ladsgroup, Lahi, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331
Cc: thiemowmde, daniel, Aklapper, Ladsgroup, Lahi, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
