| Lucas_Werkmeister_WMDE added a comment. |
The simplest fix for this is trivial:
diff --git a/view/resources/templates.php b/view/resources/templates.php index 5efe5bd65..5da5e66e7 100644 --- a/view/resources/templates.php +++ b/view/resources/templates.php @@ -90,7 +90,7 @@ $templates['wikibase-statementview'] = <<<HTML -<div class="wikibase-statementview wikibase-statement-$1 wb-$2"> +<div id="$1" class="wikibase-statementview wikibase-statement-$1 wb-$2"> <div class="wikibase-statementview-rankselector">$3</div> <div class="wikibase-statementview-mainsnak-container"> <div class="wikibase-statementview-mainsnak" dir="auto"><!-- wikibase-snakview -->$4</div>
HTML5 allows any characters in the id attribute, including $. MDN warns against this because it wasn’t allowed in HTML4, but does anyone know what old browsers do in that case? As long as they don’t crash, I’m not convinced this is something we need to watch out for.
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331
Cc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
