| thiemowmde added a comment. |
During todays discussion round there was huge confusion what this ticket here should be about: Is it exclusively about Lua? If so, why? Shouldn't this be about fine-grained usage tracking and change notifications in general? And what does "fine-grained" include? Tracking statements and descriptions as well?
Here is my attempt to answer these questions:
- The ticket for description tracking is T151717: Usage tracking: record which statement group is used. The vast majority of this is done.
- The ticket for individual statement tracking is T106287: [Tracking] Track descriptions usages separately (Create a new description usage aspect "D"). Again, the vast majority of this is done.
- The parser functions already do description tracking as well as individual statement tracking, see https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/client/includes/DataAccess/StatementTransclusionInteractor.php;165ae7b34412c848d8b123532a25d6ce76b0f646$108.
- The specific Lua functions also do both.
- The only thing not covered by T151717 and T106287 is to teach the generic getEntityObject Lua function (that really should be the only one, as far as I can tell) to do fine-grained tracking.
- The patch https://gerrit.wikimedia.org/r/392041 (a resubmission of the original https://gerrit.wikimedia.org/r/371651) is incomplete. There are two ways forward:
- Via a feature flag: The patch could be expanded to (temporarily) understand the disabledUsageAspects setting. This will allow us to merge the patch without having an effect in production. Only if the setting is removed in production, all code (both the parser functions as well as all Lua functions) will start tracking descriptions and statements individually.
- By reversing the dependency: We need to enable individual statement usage notifications first (on all of production), and only then can we start working on this patch again. I'm not sure if this makes sense.
TASK DETAIL
EMAIL PREFERENCES
To: eranroz, thiemowmde
Cc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Gq86, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331
Cc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Gq86, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
