| Lucas_Werkmeister_WMDE updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
~~If we do implement {T180796} as part of this, then I think we could just turn `DelegatingConstraintChecker` into this layer. Its current interface (`checkAgainstConstraintsOnEntityId`, -`ClaimId`) doesn’t make too much sense in the presence of `ConstraintCheckPlan` anyways.~~
#patch-for-review:
- [x] https://gerrit.wikimedia.org/r/395007
- [x] https://gerrit.wikimedia.org/r/395558
- [ ] https://gerrit.wikimedia.org/r/395559
...
**Output:** A JSON blob (as PHP array structure, not string) of constraint check results. We could also return a list of `CheckResult`s, but that would mean that in the most common case (API request with cache hit), we would deserialize those `CheckResult`s from the cache only to serialize them into JSON again immediately, which seems rather unnecessary to me. I’d rather return JSON at this level directly, make the API simply pass it through, and update the special page to operate on the JSON instead of a `CheckResult[]`. (We still have a JSON string → PHP array → JSON string roundtrip, but that can’t be avoided since the API request might also have requested XML results.)~~If we do implement {T180796} as part of this, then I think we could just turn `DelegatingConstraintChecker` into this layer. Its current interface (`checkAgainstConstraintsOnEntityId`, -`ClaimId`) doesn’t make too much sense in the presence of `ConstraintCheckPlan` anyways.~~
#patch-for-review:
- [x] https://gerrit.wikimedia.org/r/395007
- [x] https://gerrit.wikimedia.org/r/395558
- [ ] https://gerrit.wikimedia.org/r/395559
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: gerritbot, Jonas, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331
Cc: gerritbot, Jonas, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
