thiemowmde added a comment.

@Ladsgroup, the numbers in my comment are from my local codebase and not something others can work on.

Note that the only problematic class_exists checks are the ones that don't utilize the …::class feature. class_exists( Babel::class ) is fine, but class_exists( '\Babel' ) is not. Only the later should be cleaned up systematically. In many cases it's just fine to do a class_exists check, especially if the code below actually uses the very same class. For example, class_exists( WikibaseRepo::class ) should (in my opinion) not be replaced with an extension registration check, because that would introduce the problematic string "Wikibase Repository" I don't want to hard-code in to many places.


TASK DETAIL
https://phabricator.wikimedia.org/T183096

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, CKoerner_WMF, MuhammadShuaib, KasiaWMDE, SimmeD, Wikidata-bugs, jayvdb, Tobi_WMDE_SW, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to