Jan_Dittrich added a comment.

It does not look nice, indeed. On the other hand, I assume it was never designed systematically (in the sense of "If we put IDs in the header, where else do we use this element?"). So I would frame it as a bit of (non-wicked) design debt. Like with technical debt, we might want to refactor it.

I would put the qID in the " "

Why? – Semantically we have 2 elements here:

  • the Explanation text ("Difference between revisions of") and…
  • the page title and the ID, both being different ways to point to the same concept.

Currently, we have the " " as the separator. They should remain the separator (to keep semantic clarity), even if it looks not awesome.
But actually, " " should be HTML tags that mark up the parts and then we could apply other styling than "" (The "" correspond to a pattern I also see in other areas of MW, where chaining strings seems to have been the way to go to highlight semantical difference, so there are characters like ", | , [ instead of tags)
You may know this from scientific (or other highly structured publications where book titles that are cited rarely appear as "War and Peace" but nicer as War and Peace (good writing tools also allow "" but they are inserted automatically by your citation management)

For a possible refactoring:

  • Put tags where the "" are and reintroduce them via CSS::after /::before (so no visual change done. but a better code structure)
  • When we have a style they should have, just lets change the CSS

TASK DETAIL
https://phabricator.wikimedia.org/T181077

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jan_Dittrich
Cc: Lucas_Werkmeister_WMDE, Charlie_WMDE, Jan_Dittrich, thiemowmde, Lydia_Pintscher, Aklapper, matej_suchanek, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, JGirault, Wikidata-bugs, aude, TheDJ, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to