Hi everyone,I was playing around with https://bugzilla.wikimedia.org/show_bug.cgi?id=46217 ( Implement a special page to show items with the most sitelinks) and I noticed these kind of statistics pages are implemented quite differently. Take for example in https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=tree;f=includes/specials . If you look for the "most" special pages you'll have getQueryInfo() for the query and formatResult() to format the rows. That seems to be pretty consistent.
At the moment we seem to have two statistics special pages:* https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=blob;f=repo/includes/specials/SpecialEntitiesWithoutLabel.php * https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=blob;f=repo/includes/specials/SpecialItemsWithoutSitelinks.php
Both seem to be structured quite differently than the normal special pages. Wouldn't it be better to structure https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=blob;f=lib/includes/specials/SpecialWikibaseQueryPage.php more like https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/QueryPage.php or maybe even extend it?
Maarten _______________________________________________ Wikidata-tech mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
