On Mon, Sep 29, 2014 at 3:22 PM, Daniel Kinzler <[email protected] > wrote:
> Hi Amir! > > On a first glance, it seems that you are right: it would be nicer if > SpecialUnconnectedPages derived from QueryPage. I would not call the > current > implementation "incorrect" though. As far as I know, it works as designed. > > Main issue on this special page is that doesn't have an API equivalent (like AncientPages, etc.) and that's because it doesn't use QueryPage. Similar extensions like Disambiguator use a simple hook to add their special pages to QueryPages array in mw core and get the api equivalent easily. > When rewriting the special page, please use proper dependency injection. > Since a > few weeks ago, it is now possible to register special pages using a factory > method, so we have full controll over the constructor parameters. > > I'll check. Thank you. > -- daniel > > Am 25.09.2014 16:01, schrieb Amir Ladsgroup: > > Hello, > > If you check the php file of SpecilUnconnectedPages (in > > Wikibase/client/includes/specials/) it extends SpecialPage instead of > QueryPage. > > I want to know is it intentional? if it's not Do you agree it's better to > > rewrite the file to use the QueryPage class? > > > -- > Daniel Kinzler > Senior Software Developer > > Wikimedia Deutschland > Gesellschaft zur Förderung Freien Wissens e.V. > > _______________________________________________ > Wikidata-tech mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikidata-tech > -- Amir
_______________________________________________ Wikidata-tech mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
