Thanks for the info. Then we will also treat null and "0" as error and assume arcsecond precision for these cases. We will not log warnings, however, since here are thousands of cases of this in the dump which would always swamp the log :-(. Would be good to have a bot fix this at some point.

Cheers,

Markus

P.S. I think I will also give up my opposition to double as a data format, and change Wikidata Toolkit to use double for all coordinates as well. With the elimination of fixed precisions, there is no longer any requirement to compare the data using "==" (which is just wrong for doubles).


On 12.01.2015 17:52, Jeroen De Dauw wrote:
Hey,

    Looking at GeoCoordinateFormatter, I see this:

    if ( $precision <= 0 ) {
             $precision = 1 / 3600;
    }


As additional context: this was added only last November.

Cheers

--
Jeroen De Dauw - http://www.bn2vs.com
Software craftsmanship advocate
Evil software architect at Wikimedia Germany
~=[,,_,,]:3


_______________________________________________
Wikidata-tech mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech



_______________________________________________
Wikidata-tech mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Reply via email to