Hi Antonin, No, that's not correct, that was changed a few years ago. I've been keeping up (well, trying to!). Here's the post from Stas from 4 years ago. https://lists.wikimedia.org/hyperkitty/list/[email protected]/thread/CPGZSC55XFU5HPSRJNZWDQOKLZDHKJSA/#S7J5EZG5TIBNFXRRWVHGCXC4X6RSZ65Q
The reason I asked about the comma token is that I seemed to recall, perhaps in last 3 years? that it would not affect the simple search (aka wbsearchentities API, aka suggestion dropdown box) Also, I tried to find something about that on Phabricator, but quickly got into the weeds since I don't know the labels that the team uses. The closest ones I found were these: https://phabricator.wikimedia.org/search/query/64FG3L6BYauX/#R but I have no way in the Phabricator Advanced Search to say, only those after the date of Stas' post. Thad https://www.linkedin.com/in/thadguidry/ https://calendly.com/thadguidry/ On Sun, Aug 15, 2021 at 1:47 AM Antonin Delpeuch (lists) < [email protected]> wrote: > Hi Thad, > > This suggestion box does not use ElasticSearch, it uses a simple prefix > search on labels and aliases, run directly against the SQL database, I > think. ElasticSearch is only used when you go to Special:Search. > > Best, > > Antonin > On 15/08/2021 04:25, Thad Guidry wrote: > > I thought that "," comma was being added to the Elasticsearch token filter > as a stopword and excluded from simple search now? > Or did I miss something? > > [image: image.png] > > Or NO and U+002C comma was decided against being added, and we must use > the Advanced Search on Wikidata or the API ? > > I noticed that the string "foot locker inc" will not show the entity in > the dropdown, but only "foot locker, inc." ? > (I've since added the full legal name into the alias to improve > searchability, but still would like to know the stopword decision) > > Thad > https://www.linkedin.com/in/thadguidry/ > https://calendly.com/thadguidry/ > > _______________________________________________ > Wikidata-tech mailing list -- [email protected] > To unsubscribe send an email to [email protected] > > _______________________________________________ > Wikidata-tech mailing list -- [email protected] > To unsubscribe send an email to [email protected] >
_______________________________________________ Wikidata-tech mailing list -- [email protected] To unsubscribe send an email to [email protected]
