On Fri, 15 May 2009 21:57 -0400, "Chad" <[email protected]>
wrote:
> I'm aware of the bug, I just didn't see any major reason
> to do it. However, consistency is always good and this
> is a pretty low-impact change.
>
> -Chad
>
> On May 15, 2009 9:50 PM, "Karun Dambiec" <[email protected]> wrote:
>
>
>
> On Fri, 15 May 2009 21:44 -0400, "Chad" <[email protected]>
> wrote:
>
> > That should be a part of your patch, renaming the files. > If you renamed
> via svn, then it should ...
> I wasnt aware SVN had a rename option. Ill update the patch to include
> renaming the files.
> Probably the main reason to rename them is that in the maintenance
> directory, the standard is .inc, whereas there are a few, but not many
> with .inc.php as the extension
> And there was a bug report submitted to fix it.
I have tried generating a diff file from svn with the renames, however I
only get the following in the diff file:
Property changes on: maintenance/importImages.inc
___________________________________________________________________
Added: svn:mergeinfo
I have had a discussion on #svn about it, and it appears svn diff does
not give the details of the rename. So instead I have just added the
list of files and the new names to the patch.
Regards
Karun
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
