You're patching already-existing functionality at the File level, so it should be ok to just plop it in there. I'm not sure how this will affect the ForeignApi interface, so it'd be worth testing there too.
From what I can tell at a (very) quick glance, it shouldn't adversely affect anything from a client perspective on the API, as we just rely on whatever URL was provided to us to begin with. -Chad On Fri, Jun 26, 2009 at 3:31 PM, Sergey Chernyshev<[email protected]> wrote: > Which of all those file to change to apply my patch only to files in default > repository? Currently my patch is applied to File.php > > http://bug-attachment.wikimedia.org/attachment.cgi?id=5833 > > If you just point me into right direction, I'll update the patch and upload > it myself. > > Thank you, > > Sergey > > > -- > Sergey Chernyshev > http://www.sergeychernyshev.com/ > > > On Fri, Jun 26, 2009 at 3:17 PM, Chad <[email protected]> wrote: > >> The structure is LocalRepo extends FSRepo extends >> FileRepo. ForeignApiRepo extends FileRepo directly, and >> ForeignDbRepo extends LocalRepo. >> >> -Chad >> >> On Jun 26, 2009 3:15 PM, "Sergey Chernyshev" <[email protected]> >> wrote: >> >> It's probably worth mentioning that this bug is still open: >> https://bugzilla.wikimedia.org/show_bug.cgi?id=17577 >> >> This will save not only traffic on subsequent page views (in this case: >> >> http://www.webpagetest.org/result/090218_132826127ab7f254499631e3e688b24b/1/details/cached/it's<http://www.webpagetest.org/result/090218_132826127ab7f254499631e3e688b24b/1/details/cached/it%27s> >> about 50K), but also improve performance dramatically. >> >> I wonder if anything can be done to at least make it work for local files - >> I have hard time understanding File vs. LocalFile vs. FSRepo relationships >> to enable this just for local file system. >> >> It's probably also wise to figure out a way for it to be implemented on >> non-local repositories too so Wikimedia projects can use it, but I'm >> completely out of the league here ;) >> >> Thank you, >> >> Sergey >> >> >> -- >> Sergey Chernyshev >> http://www.sergeychernyshev.com/ >> >> On Fri, Jun 26, 2009 at 11:42 AM, Robert Rohde <[email protected]> wrote: >> > >> I'm going to mention ... >> _______________________________________________ >> Wikitech-l mailing list >> [email protected] >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l >> > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
