Brion Vibber <[email protected]> wrote:

>> Here's what I do in similar circumstances.  Create another variable,
>> $wgScriptPathEscaped.  Then, gradually make the changes.  Wait for tests.
>> Change some more.  Eventually, most of the old ones will be gone.

> $wgScriptPath is a URL fragment, and by definition MUST be properly
> URL-escaped.

> There is no need for a second variable; it just needs to be initialized
> correctly -- something that never got done because it's extremely rare
> to stick a web app in a folder that has characters that would need escaping.

It just needs to be *documented* correctly :-).

Tim


_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to