On Thu, Jun 10, 2010 at 11:40 AM, Mark A. Hershberger <[email protected]> wrote: > (Realized I hadn't actually subscribed, so re-sending.) > > Chad <[email protected]> writes: > >> mah - 5 > > When a FIXME is fixed, my understanding is that the fixer isn't > supposed to un-mark the FIXME. If I'm wrong, I'll toggle a few of these > to RESOLVED. Looking at the recent state changes, it isn't clear that > the committer is supposed to mark it RESOLVED. >
This is a general note to all committers, since I keep seeing the same question asked. Committers should never set their own revisions to "OK" or "RESOLVED." Even if you review code, review other people's code and let other people review yours :) -Chad _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
