On Fri, Jul 23, 2010 at 7:04 PM, Platonides <[email protected]> wrote: > I don't see anything obvious breaking. Of course, external links stop > working, both plain and in [], also magic external images, and the > captcha won't detect it as addition of urls. > But all of that seems expected behavior on removing http from > $wgUrlProtocols.
It's not what he asked for. He only asked for disabling bare links, not explicit external links like [http://...]. > You mentioned Special:LinkSearch and wfParseUrl(), but LinkSearch has > nothing to search if you don't allow external links, and wfParseUrl() is > only used inside the parser (precisely to work with the previously > matched external urls). It also looks like it will break API pretty-printing (see ApiFormatBase::formatHTML()), and do something in Sanitizer::safeEncodeAttribute() (not sure what), and prohibit use of <a href=""> and <img src=""> if those are enabled, and break any scripts that use wgUrlProtocols, and do something unexpected to the 'edithelppage' message functionality by breaking Skin::makeInternalOrExternalUrl(), and break the 'sidebar' message if you use URLs as keys, and break stripping of URLs during section anchor generation (Parser::stripSectionName()), and undoubtedly various other things that I didn't spot in this cursory inspection, not even counting extensions. So, yeah, I'm going to stand by "don't ever remove stuff like http:// from $wgUrlProtocols". _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
