User "Krinkle" changed the status of MediaWiki.r84985. Old Status: new New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r84985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84985#c15590 Comment: Please use <code>window.console</code> instead of <code>console</code>. For one because right now it throws a ReferenceError exception when console is undefined! (Marking FIXME for that) ...whereas checking an object member of window never fails with a ReferenceError, it just returns null / undefiend -> implied false. Another solution would be to check <code>typeof == 'undefined'</code>, but using window is shorter and also fixes the high unlikely case would there be a local variable called "console". _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
