User "Duplicatebug" posted a comment on MediaWiki.r64774.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/64774#c15601
Comment:
It is bad, when the content defaults to an empty string, because some caller
only check for false.
>From Import.php
<pre>
$data = Http::request( $method, $url );
if( $data !== false ) {
</pre>
When the url is a redirect and that redirect is not automatically resolved (see
r67684), than the status is OK and Http::request returns (correctly) the
content and that is the default empty string, but there should be no content.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
