User "Brion VIBBER" changed the status of MediaWiki.r85553. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r85553. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85553#c15768 Comment: This doesn't seem to have fixed everything; while the tests now run, 13 tests fail that didn't in r85301 before this stuff changed, mostly related to LanguageConverter which may indicate that language objects still are off somehow: 13 new FAILING test(s) :( * Prevent conversion with -{}- tags (language variants) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Prevent conversion of text with -{}- tags (language variants) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Prevent conversion of links with -{}- tags (language variants) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * -{}- tags within headlines (within html for parserConvert()) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Explicit definition of language variant alternatives [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Explicit session-wise language variant mapping (A flag and - flag) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Explicit session-wise language variant mapping (H flag for hide) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Adding explicit conversion rule for title (T flag) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Bug 24072: more test on conversion rule for title [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Raw output of variant escape tags (R flag) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Nested using of manual convert syntax [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Do not convert roman numbers to language variants [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] * Edit comment with bare anchor link (local, as on diff) [Introduced between 06-Apr-2011 19:06:48, 1.18alpha (r85302) and 06-Apr-2011 19:10:58, 1.18alpha (r85562)] Passed 641 of 654 tests (98.01%)... 13 tests failed! Also it seems odd to set $wgContLang to $langObj, then set it to $context->lang immediately after. If that's because something in RequestContext()'s constructure requires $wgContLang to be set, then you should mention this in a comment so someone else doesn't come along and remove it, thinking it's redundant. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
