User "Platonides" changed the status of MediaWiki.r85573. Old Status: new New Status: ok
User "Platonides" also posted a comment on MediaWiki.r85573. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85573#c15769 Comment: Nice. The usual approach for the static is to add another function to clear the caching, but if accessing the regex is fast enough, it is fine. I don't see why there would be a slowdown there in the current code. It should hit :LocalizationCache:loadedItems. The added testcases pass. Marking ok. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
