User "Platonides" changed the status of MediaWiki.r85327. Old Status: new New Status: fixme
User "Platonides" also posted a comment on MediaWiki.r85327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c15793 Comment: You are using too many ways of detecting HipHop: wfDetectCompiledMode(), wfIsHipHop(), defined( 'MW_COMPILED' ), function_exists( 'hphp_thread_set_warmup_enabled' ), ReflectionFunction( 'wfHipHopCompilerVersion' ); I think Sanitizar::$attribsRegex should be a function static I'm not convinced about the change in Names.php. In any case, you missed removing its require and global from the top of Language.php Otherwise it's ok _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
