User "Tim Starling" posted a comment on MediaWiki.r85327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c15851
Comment: The ReflectionFunction boilerplate and the function_exists() detect two different things: one detects compiled mode and the other detects HipHop, whether it's compiled or interpreted. These correspond to defined( 'MW_COMPILED' ) and wfIsHipHop() in the bulk of the codebase, however it's not possible to use them before they exist, and it's not possible to make sure they exist without first checking for HipHop. That's why the relevant code needs to be duplicated in WebStart.php and Maintenance.php. wfDetectCompiledMode() is a helper function for use inside WebStart.php only, and is used to set MW_COMPILED. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
