User "Krinkle" changed the status of MediaWiki.r85885. Old Status: fixme New Status: new
User "Krinkle" also posted a comment on MediaWiki.r85885. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15865 Comment: Note: I have no experience with lbm_db2. I've looked at the first half dozen diffs, here's some general notes: <pre> --- includes/db/DatabaseIbm_db2.php +++ includes/db/DatabaseIbm_db2.php 460 + //TODO: Remove commented-out debug code once done debugging 470 + //echo '<pre>ERROR</pre>'; 471 + //echo '<pre>' . $sql . '</pre>'; 472 $error = db2_stmt_errormsg(); 473 + //echo '<pre>' . $error . '</pre>'; </pre> This needs to be removed <pre> 498 - $sql = <<< EOF 498 + /*$sql = <<< EOF 502 + $sql = "SELECT COUNT( * ) </pre> I guess the new value is better, but the old one doesn't have to stay in /* comments */, should be removed as well. <pre> 905: - //$this->installPrint( "Preparing the following SQL:" ); 905 + $this->installPrint( "Preparing the following SQL:" ); </pre> The previous code on that line (which appears to be debug left by a previous developer) was uncommented. Should this be commented out again ? There's probably a bit more of this. I haven't looked further. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
