User "Mormegil" posted a comment on MediaWiki.r85876.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85876#c15913

Comment:

The code using ''Emailnotarget'' is broken: Since <code>target</code> is used 
only if <code>$par</code> is not received, you are not able to override a bad 
username by submitting a corrected one, the ''original'' is still checked. Try 
going to e.g. [[translatewiki:Special:Emailuser/NonexistentUser]] and 
submitting a different valid username.

You either need to change <code>userForm</code> so that it submits to the 
special page without the optional username parameter, or invert the order when 
retrieving <code>$this->mTarget</code> in <code>execute</code>.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to