User "Platonides" posted a comment on MediaWiki.r85922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15924
Comment:
- if ( $line === '' ) { # empty line, go to next line
+ if ( $line == '') { //empty line, go to next line
Why are you changing the strict equality to a weak one? Probably introduces
some bug.
:Oh, it was fixed in r85943
You're changing the tag history to using a stack. I'd appreciate some docs on
the way it is done.
It's probably ok, but would be easier to review it with an explanations.
Also, the new way looks more memory hungry.
_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
