User "Jack Phoenix" posted a comment on MediaWiki.r86011.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86011#c15935
Comment:
Some minor [[Manual:Coding conventions|coding style]] issues here:
*$welcome_creation_msg should be called $welcomeCreationMsg
*I'd prefer a space after the double slashes: <code>// let any extensions
change what message is shown</code>
*space after ) and before { (<code>if( $msgname ) {</code>)
docs/hooks.txt should also be updated.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
