User "Catrope" changed the status of MediaWiki.r85953. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r85953. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85953#c15941 Comment: <pre> - title = new mw.Title( result.title ).setNamespace( 'file' ).getNameText(); + title = new mw.Title( result.title ).setNamespace( 'file' ); } catch ( e ) { // unparseable result from unique test? title = '[unparseable name]'; </pre> The code below treats <code>title</code> as an <code>mw.Title</code> object, even though the catch path sets it to a string. Calling <code>.toString()</code> on a string is safe though, but calling <code>.getNameText()</code> is not. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
