User "Freakolowsky" changed the status of MediaWiki.r85906. Old Status: new New Status: fixme
User "Freakolowsky" also posted a comment on MediaWiki.r85906. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85906#c15981 Commit summary: Change the duplicateTableStructure() to use the original names. It is now duplicateTableStructure() duty to addIdentifierQuotes() them. Fixed bug for mysql < 4.1 where the new name would be quoted twice. Always quote identifier in Oracle, doing otherwise seems a bug (can someone confirm?) Comment: This will not fly!!! You are reading documentation for Oracle 10g (10.2) ... the current state of Oracle code in MW is written for 9i (9.2) which has very limited (i.e. some but buggy) support for object naming in quotes and most of people i know use 9i for MW. So could you please STOP trying to stuff these quotes in the code every 2 months. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
