User "Reedy" posted a comment on MediaWiki.r86105.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86105#c15989
Commit summary:
Useful extension by Milan allowing files to be attached to pages
Comment:
<pre>
+ function __construct() {
+ global $wgHooks;
+ $wgHooks['BeforePageDisplay'][] = $this;
+ $wgHooks['UploadForm:initial'][] = array( $this,
'onUploadFormInitial' );
+ $wgHooks['UploadForm:BeforeProcessing'][] = array( $this,
'onUploadFormBeforeProcessing' );
+ $wgHooks['SkinTemplateTabs'][] = $this;
+ $wgHooks['SkinTemplateNavigation'][] = $this;
+ }
</pre>
Shouldn't all of those be arrays, rather than just passing a class reference
and no target method?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
