User "Nikerabbit" changed the status of MediaWiki.r86105. Old Status: new New Status: fixme
User "Nikerabbit" also posted a comment on MediaWiki.r86105. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86105#c15997 Commit summary: Useful extension by Milan allowing files to be attached to pages Comment: It works that way too. It will call $that->onHookName(). But more importantly those should be registered on the main level and use static methods. +if( $attachto = $wgRequest->getText( 'attachto' ) ) { + $out->mBodytext = str_replace( "</form>", "<input type=\"hidden\" name=\"attachto\" value=\"$attachto\" /></form>", $out->mBodytext ); Somebody forgot the escaping? Title::newFromText( 'Upload', NS_SPECIAL ) Should use SpecialPage::getTitleFor( 'Upload' ) or similar. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
