User "Bawolff" changed the status of MediaWiki.r86100. Old Status: fixme New Status: new
User "Bawolff" also posted a comment on MediaWiki.r86100. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86100#c16015 Commit summary: (bug 28540) revert r83544 - It really breaks things when using uca-default collation (As noticed on tw) Various functions (particuarly the getFirstCharacter ones) all expect to have the human readable sortkey. Passing them the binary sortkey results in the getFirstChar headers to be totally wrong. It also causes paging not to work since the sortkey gets double encoded. This issue probably wasn't noticed, since it wouldn't be visible on the uppercase collation as uppercasing the first letter won't affect the first character headings, nor does double uppercasing something matter. Also changed one of the variable names from $rawSortkey to $humanSortkey as it confused me (raw as in before turning to binary, or raw as in the real non-human readable sortkey) Comment: Sounds like a good plan. Did that in r86121. resetting revision to new _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
