User "Reedy" changed the status of MediaWiki.r86174. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86174#c0 Commit summary: (Follow-up r86169) Fix three minor issues Reedy found. * Some strings were using double quotes needed the dollar sign escaped. (the strings had to do with detecting obscure text encodings for IPTC) * FormatMetadata::collapseContactInfo should be static (for some reason I never got any E_STRICT on this. I think the api suppresses E_STRICT somehow...) * Exif::get/makeFormattedMetadata method (which appears to no longer be used, and never was used, but kept in for compatability just in case) called another function without required argument. Also got changed from public to private somehow (which is generally a bad idea, especially when its only reason for being there is to preserve back-compat). Marked these functions as deprecated while I'm at it since they really should not be used. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
