User "Bawolff" posted a comment on MediaWiki.r86175.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86175#c16060
Commit summary:

First step of reorganizing profiling files:
* Move them all to includes/profiling/* - If you're using StartProfiler, you'll 
need to update that
* Make ProfileStub subclass the Profiler rather than duplicating function 
definitions conditionally
* Removed unused params to wfGetProfilingOutput(), only used in the stub, and 
they didn't do anything with them
* TODO: Kill $wgProfiling, make $wgProfiler a config array and move the various 
options to that. Also make into a singleton, rather than global (not much calls 
it outside of core)

Comment:

When running eval.php

Strict Standards: Declaration of ProfilerStub::profileOut() should be 
compatible with that of Profiler::profileOut() in 
/var/www/w/phase3/includes/profiler/ProfilerStub.php on line 57


(btw, does this fix bug 26220)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to