User "Tbleher" posted a comment on MediaWiki.r85250.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85250#c16074
Commit summary:
Continue with r85240; Move getSkin from User to RequestContext, do it without
globals, strip out the non-functional $title related stuff, and update Skin to
use a RequestContext.
Comment:
Could you fix the DumpHTML extension that was broken by this change?
Call to undefined method SkinVector::setTitle
Backtrace:
#0 [internal function]: Skin->__call('setTitle', Array)
#1 /srv/www/mediawiki/extensions/DumpHTML/dumpHTML.inc(819):
SkinVector->setTitle(Object(Title))
#2 /srv/www/mediawiki/extensions/DumpHTML/dumpHTML.inc(482):
DumpHTML->getArticleHTML(Object(Title))
#3 /srv/www/mediawiki/extensions/DumpHTML/dumpHTML.inc(209):
DumpHTML->doArticle(Object(Title))
#4 /srv/www/mediawiki/extensions/DumpHTML/dumpHTML.inc(148):
DumpHTML->doArticles()
#5 /srv/www/mediawiki/extensions/DumpHTML/dumpHTML.php(152):
DumpHTML->doEverything()
#6 {main}
I do not know enough about the new RequestContext stuff to properly fix this
extension.
(Small general question: should a revision be marked "fixme" if it breaks an
extension not currently used by the WMF?)
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
