User "^demon" posted a comment on MediaWiki.r86312. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86312#c16078 Commit summary:
Followup rr86304 We need a title object for parsing, do one against the message key Doesn't seem to be the best way, but it's the most applicable. If I abused $wgTitle, Chad would come and beat me too ;) Comment: Should probably check to make sure we return a valid Title from newFromText(). I imagine the scenario of feeding an invalid title (or string that makes one) is fairly rare. Just throw an exception? Also, you don't need () around the instanceof check, you can just do !$a instanceof B _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
