User "MarkAHershberger" changed the status of MediaWiki.r83804. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83804#c0 Commit summary: Various fixes: *Make this a non-includable special page. A special page calling $wgOut->disable, and then outputting an xml document should not be transcludable. Bad things happen. *Move the $wgFeedClasses setup into the setup file. It shouldn't only sometimes be loaded. *Remove the $parser->transformMsg calls. They're unnessary (you're not going to put {{MAGICWORDS}} into url params) and probably a bad idea. *Change/fix the way it handles category url parameter. Do &category=cat1|cat2|cat3 instead of &category[]=cat1&category[]=cat2 since the former seems more mediawiki style. Also make it do stuff with the parameter, don't just extract and throw away *Make it output an empty xml document if there are no results. This seems more sane than just outputting a random string, since this is meant to be read by computers who won't understand what the string "no results" means. (Although its unclear if this makes an invalid xml sitemap, but its going to happen from time to time so we have to do something). This also fixes some php warnings. Kill the noresults message as no longer used. *Make one of the errors an exception since it should really never never happen (Only could happen if the hardcoded fallback category is not a valid title, which is fairly impossible.) Kills badfeed message. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
