User "Catrope" changed the status of MediaWiki.r86558. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r86558. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86558#c16199 Commit summary: Auto suggest tags. Comment: Cool feature, thanks for implementing this! A few remarks: * Before calling <code>$.getJSON()</code>, you should check whether there's already a request running by checking against <code>$(this).data( 'request' )</code> . Right now multiple API requests will be made if you send a rapid succession of key presses into the textbox the first time (this is the fixme) * It would be cool if you could use the advanced features that <code>$.suggestions</code> offers (I don't remember how they work, it's been almost two years) to only display <code>baz</code> instead of <code>foo, bar, baz</code> when entering a third tag into the text box * It would be nice if the autocompletion takes tags already added to the revision (but not present in the text box) into account and doesn't suggest them again * Once you're using that tags-already-present data, you should already be halfway writing a similar suggestion feature for the remove tags text box, which would be awesome :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
