User "Catrope" posted a comment on MediaWiki.r86150.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86150#c16307
Commit summary:
refactored Feedback tool out of uploadwizard. Still dependent on some UW
libraries but this is going to be generally useful
so we might as well start separating it.
made Feedback generally easier to read, now an object managing its state
internationalized some remaining english strings
eliminated various string hacking and such with mw.Title and the linking
features in mediawiki.language.parser
added a 'newSection' method to mw.Api.edit.js, so Feedback could call it
Comment:
<pre>
+ _this.buttons[ gM( 'mwe-upwiz-feedback-cancel' ) ] =
function() { _this.cancel(); };
+ _this.buttons[ gM( 'mwe-upwiz-feedback-submit' ) ] =
function() { _this.submit(); };
</pre>
Can't you just use <code>_this.buttons[ gM( 'foo' ) ] = _this.cancel;</code> ?
<pre>
+ message = "<small>User agent: " + navigator.userAgent +
"</small>\n\n"
+ + this.messageInput.value;
</pre>
This leaks <code>message</code> into the global scope.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
