User "Krinkle" posted a comment on MediaWiki.r86625.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86625#c16332
Commit summary:

(bug 27833) CollapsibleTabs doesn't collapse tabs due to JS errors
* Change remove() to detach() so .data() isn't lost
* Be more careful using the parent's .data() in addData()
* Change ele (which mysteriously isn't available in the closure) to this, 
they're the same anyway

Comment:

I checked in Firefox and returns null there as well.

However I did this on mediawiki.org (jQuery 1.4.2), not /trunk, and it returned 
null. On translatewiki.net (jQuery 1.4.4) it does indeed return undefined.

So I guess this changed in 1.4.4 rather than 1.5. Anyway, it might change in 
the future as well. Not sure why they changed it.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to