User "Krinkle" posted a comment on MediaWiki.r85049.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85049#c16347
Commit summary:

Simplified buckets, created a possible framework for user bucket campaigns

Comment:

Some random points:
* Check code conventions (whitespace, new line end of file, single quotes etc. 
): [[Manual:Coding conventions]]
* The global <code>mediaWiki</code> is always available, including its alias 
"<code>mw</code>". <code>MW</code> (capital) however does not exist, please 
remove the check and use the lowercase alias.  
* Don't depend on <code>$</code>. And <code>$j</code> is a legacy alias. 
Instead, use <code>jQuery</code> and locally alias it to <code>$</code> by 
using an Immediately-Invoked Function Expression as shown 
[[Manual:Coding_conventions#jQuery|here]].

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to