User "Krinkle" posted a comment on MediaWiki.r86991.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86991#c16366
Commit summary:

Finished rendering methods, added styling, and i18n/L10n (which also resolves 
issues in r86742).

Comment:

<source lang="diff">
--- revision 86990
+++ revision 86991

-       protected function renderTable( array $headings, array $rows, $id = 
null ) {
+       protected function renderTable( $caption, array $headings, array $rows, 
$id = null ) {
                global $wgOut;
 
                $table = Html::openElement( 'table', array(
                        'class' => 'articleFeedback-table sortable', 'id' => $id
                ) );
+               // Caption
+               $table .= Html::element( 'caption', array(), $caption );
                // Head
</source>

Not all tables have a caption right ? This seems to uncondionally add an 
(empty) caption..

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to