User "Krinkle" changed the status of MediaWiki.r86202. Old Status: new New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r86202. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86202#c16382 Commit summary: Free metadata toggle script from wikibits.js dependencies; rename to mediawiki.action.view.metadata.js Comment: <pre> + if ( $table.is( '.collapsed' ) ) { </pre> jQuery's is() function is very flexible but also relatively slow. Use more specific alternatives when possible. Such as <code>hasClass</code>. ([http://jsperf.com/is-classname-vs-hasclass jsperf comparison]). <pre> + $table.toggleClass( 'expanded, collapsed' ); </pre> This doesn't work (atleast not in the most recent version of jQuery). toggleClass is able to toggle multple classes indepently, but does not take input in comma seperated string. Instead it takes a space seperated string (see also [http://api.jquery.com/toggleClass/ jQuery.fn.toggleClass documentation]); Fixed in r87052. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
