User "Nikerabbit" posted a comment on MediaWiki.r87046.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87046#c16393
Commit summary:
AFT/ClickTracking JsPerf + JsLint fixes:
* Combining (function($){}(jQuery); and $(document).ready (check
[[Conventions]] for details)
* Cache $(this) instead of re-initializing the same object multiple times.
* Don't use .each() for plugings that do this already internally. (ie.
.remove(), .css() etc.)
* Make use of jQuery chaining where possible
($(...).foo().bar().more().calls(); etc.);
* Delete $.json_encode, using jquery.json module instead
* Use dot.notation instead array['brackets'] whenever possible.
* Using Array literal instead of Object constructor (var = []; / var = new
Array();)
Comment:
Is this correct?
<pre>
-} )( jQuery );
\ No newline at end of file
+} )();
\ No newline at end of file</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
