User "^demon" changed the status of MediaWiki.r83808. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83808#c0 Commit summary: Cleanup parts of GNSM, especially parts relating to the SitemapFeed class and FeedSMItem. *Make it so fatal errors cannot be generated by using an invalid feed name *Make it so no more fatal if feed=sitemap on some other page (This part is somewhat borked though, as it assumes a feed item title is a page title, which is true on say Special:Recentchanges, but not ?action=history. Its not expected that anyone would want to do that, maybe could output (500) error if not given a FeedSMItem(?) *Remove usenamespace, usecurid, and supresserrors parameters. They're carried over from DPL, and useless here. *Remove weird stuff with $wgLocalTimezone (Don't know what the intention with it was). *Have sensible errors with 500 status code, instead of random text. Make having no results not be an error since it could happen, and saying Error no results is not machine readable, like an xml document with no entries (which might not be valid according to the schema, but certainly better than the alternative) *Generally fix up which parameters are needed for the feed. Reduce code duplication with ChannelFeed class. and unify the Sitemap and other feed types somewhat. *Remove feedItemAuthors() and feedItemDesc that appearently are dead code *Don't make the talk page a comment page advertized by atom. On en wikinews, the apropriate page is the comments namespace. Look into how that parameter is actually used, and potentially re-add later. *Make the atom feed component return the article as the description. Might be slightly inefficient (?) but so is the rest of the extension ;). Certainly better than returning nothing *Remove priority feature. Doesn't really make sense since we have no way of figuring out what has a high priority. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
