User "Brion VIBBER" changed the status of MediaWiki.r87129. Old Status: fixme New Status: reverted
User "Brion VIBBER" also posted a comment on MediaWiki.r87129. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87129#c16431 Commit summary: * (bug 21196) Article::getContributors() no longer fail on PostgreSQL Changed User::loadFromRow() to allow partial row (user_id, user_name, user_real_name can be set independently from other fields) userand removed User::$mDataLoaded, replaced by User::$mLoadedItems (marked as private) that can be an array with already loaded items or true when all data has been loaded. Changed GlobalFunctions.php and Database.php accordingly, no use of User::$mDataLoaded in extensions. Comment: Causes wild breakage like this: <pre> SkinTemplate::makeTalkUrlDetails given invalid pagename User: Backtrace: #0 /var/www/trunk/includes/SkinTemplate.php(691): SkinTemplate->makeTalkUrlDetails('User:') #1 /var/www/trunk/includes/SkinTemplate.php(495): SkinTemplate->buildPersonalUrls(Object(OutputPage)) #2 /var/www/trunk/includes/OutputPage.php(1906): SkinTemplate->outputPage(Object(OutputPage)) #3 /var/www/trunk/includes/Wiki.php(402): OutputPage->output() #4 /var/www/trunk/index.php(146): MediaWiki->finalCleanup() #5 {main} </pre> Reverted in r87152. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
