User "IAlex" posted a comment on MediaWiki.r87129.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87129#c16441
Commit summary:

* (bug 21196) Article::getContributors() no longer fail on PostgreSQL

Changed User::loadFromRow() to allow partial row (user_id, user_name, 
user_real_name can be set independently from other fields) userand removed 
User::$mDataLoaded, replaced by User::$mLoadedItems (marked as private) that 
can be an array with already loaded items or true when all data has been 
loaded. Changed GlobalFunctions.php and Database.php accordingly, no use of 
User::$mDataLoaded in extensions.

Comment:

I found FIRST() is SQLite, and worked arround the non-presence in MySQL with 
the implicitGroupby() check, but I didn't check for PostgreSQL. Will MIN() work 
correctly for strings? (sometimes I would like 
ANY_VALUE_BECAUSE_I_KNOW_THEY_ARE_IDENTICAL()).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to