User "Catrope" changed the status of MediaWiki.r85884. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r85884. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85884#c16452 Commit summary: Abstract tableName() by adding new function isQuotedIdentifier() to databases. This fixes bug in DatabaseOracle.php tableName() on line 671 and allows it to call the parent implementation instead of copying it with different quotes. Adapt Mssql addIdentifierQuotes(). Replace its addIdentifierQuotes calls with addQuotes as it's what it really is. The serialize() is probably unneeded, since I don't think it will ever be called with objects but I kept it anyway. Comment: <pre> <Reedy> Platonides, about? <Reedy> You seem to have broken table aliasing in r85884 (and possibly later commits) <Reedy> api.php?action=query&list=allusers&augroup=sysop <Reedy> Ending up with stuff like INNER JOIN `mw_`mw_user_groups` ug1` ON ((ug1.ug_user=user_id) AND ug1.ug_group = 'sysop') <RoanKattouw> Even without prefixes, I get INNER JOIN ``user_groups` ug1` </pre> I quickly tried whether reverting this rev (r85884) along with r85886, r85888, r85905, r85907 and r87143 but I got a few (fairly trivial conflicts) and it removes other useful things (such as arrays for ORDER BY) so that's not a great way of fixing this. Would be great if you could Just Fix It, or revert the feature cleanly. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
