User "GreenReaper" posted a comment on MediaWiki.r83965.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83965#c16476
Commit summary:

Fix overestimation of max-width when using perrow mode.
Also use const variables to make this more readable.

Fixes bug 27577
Follow up to r77411

Comment:

The maxwidth  calculation seems off. I had to change it to get it to this for 
the specified number of columns to be used:

$maxwidth = $this->mPerRow * ( $this->mWidths + self::THUMB_PADDING + 
self::GB_PADDING + self::GB_BORDERS + 1) + 1;

Example: 
http://en.wikifur.com/wiki/Wikifur_gallery_%28Film/media,_logos,games,misc.%29 
(running on 1.17) - try reducing max-width by even one pixel in Firebug on 
Firefox 4 and we get one less column.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to