User "Catrope" posted a comment on MediaWiki.r87031. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87031#c16481 Commit summary:
further work on FlickrChecker module Comment: <pre> + var licenseMessage = gM( 'mwe-upwiz-license-external-invalid', 'Flickr', licenseName ); </pre> There is no return statement or action in checkFlickr(), the return value is set to a local variable and discarded immediately. AFAICT this function doesn't actually '''do''' anything with the information it retrieves, surely that's wrong? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
