User "Catrope" changed the status of MediaWiki.r87225. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r87225. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87225#c16485 Commit summary: * (bug 27185) API: Add Special:ComparePages Comment: <pre> + if ( isset( $params['fromtitle'] ) ) { + $vals['fromtitle'] = $params['fromtitle']; + } </pre> Would be nice to unconditionally set <code>$vars['fromtitle'] = $rev1->getTitle()->getPrefixedText()</code> or something, so it's normalized and you get the title if you just specified a revid. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
