User "✓" posted a comment on MediaWiki.r87203.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87203#c16491
Commit summary:
(bug 28738) Implement request splitting in mw.loader so ResourceLoader requests
with query strings longer than a certain value are split up. The maximum query
string length is configurable, and this behavior is disabled by default. It's
needed in rare cases where there is a query string length or GET variable
length limit in place that the wiki admin can't raise.
Comment:
As "reqs" is an array, please don't run through it with a for-in-loop.
+ for ( var i=0; i<reqs.length; i++ ) {
+ requests[requests.length] =
$.extend(
+ { 'modules':
reqs[i].join( '|' ) }, reqBase
+ );
+ }
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
